Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39561 )
Change subject: src: Add '-Wduplicated-branches' warning option
......................................................................
Patch Set 23:
Patch Set 22:
(1 comment)
Such warning options can produce a lot of noise, e.g. false
positives. Unless there was a serious bug in the past that
would have been discovered by this, I'd prefer _not_ to use
this option.
The nvidia/tegra124 code (https://review.coreboot.org/c/coreboot/+/40430) looks like a real bug.
If the non-vendorcode code would build with that option, I believe it’s a good thing, as developers can often reorganize the code (helping other developers to understand it better).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie433f32a423ce32ea2bd5ae09a1718341cd2b672
Gerrit-Change-Number: 39561
Gerrit-PatchSet: 23
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Apr 2020 12:35:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment