Attention is currently required from: Anil Kumar K.
Karthik Ramasubramanian has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/81920?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
Patch Set 11:
(2 comments)
File src/drivers/soundwire/alc711/alc711.c:
PS11:
yes, that's the problem i see with this patch […]
I feel the address information can be filled in the devicetree as part of chip_info by adding `address` member into `struct drivers_soundwire_alc711_config`. That address information can then be filled into SSDT.
https://review.coreboot.org/c/coreboot/+/81920/comment/5c15bf15_3f58e527?usp... :
PS11, Line 162: .name = "Realtek ALC711 SoundWire Codec",
: #elif CONFIG(DRIVERS_SOUNDWIRE_ALC722)
: .name = "Realtek ALC722 SoundWire Codec",
The name can be consolidated into "Realtek ALC711/722 SoundWire Codec". I dont think this name is used for probing.
That way we can avoid separate Kconfig for ALC711 and ALC722.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 11
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Naveen M
naveen.m@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Comment-Date: Wed, 21 Aug 2024 18:36:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de