Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47659 )
Change subject: soc/intel/common/fast_spi: Add custom boot media device ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/mmap_boot.c:
https://review.coreboot.org/c/coreboot/+/47659/9/src/soc/intel/common/block/... PS9, Line 115: ext_win_size
one thing that might be nice as I was trying these patches is to see some console output indicating […]
That is a good point. I had initially added prints only for bootblock. But, the bootblock setup happens before console is initialized. So, that isn't very helpful. The other option I thought about was to do it as part of spi_flash_get_mmap_windows: https://review.coreboot.org/c/coreboot/+/48185/2/src/soc/intel/common/block/..., but not sure if that is just too late. Any other recommendations?