Stefan Reinauer (stefan.reinauer@coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9467
-gerrit
commit defcb0b150df918327632d45595bfeb8742d1cd8 Author: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.com Date: Wed Oct 29 17:26:05 2014 -0700
broadwell: Increase I2C SDA hold timing to 300ns
I2C bus SDA hold time can be marginal with 60ns value, especially when there is level shifter on the bus. So program it to 300ns based on Fast-mode specification, which is between 0 to 900ns. Apply the same timing for Standard-mode as well.
Refer to original bug on BayTrail chrome-os-partner:28092, this is to carry forward the fix to Broadwell.
BRANCH=chromeos-2013.04 BUG=chrome-os-partner:33378 TEST=suspend resume test, watch for I2C errors
Change-Id: I93200b141602163903f5c9f52b94013bcf3382a5 Signed-off-by: Stefan Reinauer reinauer@chromium.org Original-Commit-Id: 72b82a1d5d836594e7d0f95972cc0dc91ae7ff8c Original-Change-Id: I995d6868a44f2578a6d0b18dd5e8548f3c3cd494 Original-Signed-off-by: Chiranjeevi Rapolu chiranjeevi.rapolu@intel.com Original-Reviewed-on: https://chromium-review.googlesource.com/226386 Original-Reviewed-by: Wenkai Du wenkai.du@intel.com Original-Reviewed-by: Duncan Laurie dlaurie@chromium.org --- src/soc/intel/broadwell/acpi/serialio.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/soc/intel/broadwell/acpi/serialio.asl b/src/soc/intel/broadwell/acpi/serialio.asl index 6b42d54..7ffc671 100644 --- a/src/soc/intel/broadwell/acpi/serialio.asl +++ b/src/soc/intel/broadwell/acpi/serialio.asl @@ -205,8 +205,8 @@ Device (I2C0) Name (_UID, 1) Name (_ADR, 0x00150001)
- Name (SSCN, Package () { 432, 507, 9 }) - Name (FMCN, Package () { 72, 160, 9 }) + Name (SSCN, Package () { 432, 507, 30 }) + Name (FMCN, Package () { 72, 160, 30 })
// BAR0 is assigned during PCI enumeration and saved into NVS Name (RBUF, ResourceTemplate () @@ -276,8 +276,8 @@ Device (I2C1) Name (_UID, 1) Name (_ADR, 0x00150002)
- Name (SSCN, Package () { 432, 507, 9 }) - Name (FMCN, Package () { 72, 160, 9 }) + Name (SSCN, Package () { 432, 507, 30 }) + Name (FMCN, Package () { 72, 160, 30 })
// BAR0 is assigned during PCI enumeration and saved into NVS Name (RBUF, ResourceTemplate ()