[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver

[build bot (Jenkins) (Code Review)]

Attention is currently required from: Yidi Lin, Yuchen Huang.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )

Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................

Patch Set 56:

(6 comments)

File src/soc/mediatek/mt8192/pmif.c:

https://review.coreboot.org/c/coreboot/+/46878/comment/038c4cd5_9f98183f 
PS56, Line 183: 	    spi_md_ctl_pmif_rdy, spi_md_ctl_srclk_en,spi_md_ctl_srvol_en,
space required after that ',' (ctx:VxV)

https://review.coreboot.org/c/coreboot/+/46878/comment/99b9a766_7c1ef974 
PS56, Line 184: 	    spmi_md_ctl_pmif_rdy, spmi_md_ctl_srclk_en,spmi_md_ctl_srvol_en,
space required after that ',' (ctx:VxV)

File src/soc/mediatek/mt8192/srclken_rc.c:

https://review.coreboot.org/c/coreboot/+/46878/comment/c0eea3bd_402c4dc4 
PS56, Line 28: 	INIT_SUBSYS_FPM_TO_LPM = (1 << CHN_RF | 1 << CHN_DEEPIDLE | 1 << CHN_MD \
Avoid unnecessary line continuations

https://review.coreboot.org/c/coreboot/+/46878/comment/88037777_83204ce3 
PS56, Line 60: 	SUB_FPM_SET = (1 << CHN_SUSPEND | 1 << CHN_RF | 1 << CHN_MD \
Avoid unnecessary line continuations

https://review.coreboot.org/c/coreboot/+/46878/comment/27e5b624_61be978f 
PS56, Line 249: 	} else {
else is not generally useful after a break or return

https://review.coreboot.org/c/coreboot/+/46878/comment/308ec8ce_280dab9b 
PS56, Line 356: 		_BF_VALUE(CG_FCLK_FR_EN, 1) | _BF_VALUE(MUX_FCLK_FR,1));
space required after that ',' (ctx:VxV)