[coreboot-gerrit] [L] Change in coreboot[main]: mb/hp: Add HP Compaq 8300 Elite SFF

[Michał Zieliński (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Patrick Rudolph, Paul Menzel.

Michał Zieliński has posted comments on this change by Michał Zieliński. ( https://review.coreboot.org/c/coreboot/+/67666?usp=email )

Change subject: mb/hp: Add HP Compaq 8300 Elite SFF
......................................................................

Patch Set 8:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/67666/comment/d4492ecd_df6ea634?usp... :
PS8, Line 2: Author:     Michał Zieliński
> Use the company address?

I don't have one.

File Documentation/mainboard/hp/compaq_8300_sff.md:

https://review.coreboot.org/c/coreboot/+/67666/comment/3f45cce9_446c7cb2?usp... :
PS8, Line 43: Once the coreboot rom is flashed, one should remove the jumper.
> Does coreboot enable protections by default?

Removing a jumper enables write protection back on. One has to short the FDO every time they want to flash a new rom. This also applies to coreboot on this particular machine. Please note that I have tested flashing only the BIOS region.