Attention is currently required from: Elyes Haouas, Julia, Michael Büchler, Paul Menzel.
Felix Singer has posted comments on this change by Michael Büchler. ( https://review.coreboot.org/c/coreboot/+/57764?usp=email )
Change subject: mb/acer/g43t-am3: Rework mainboard for variant mechanism
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/acer/g43t-am3/variants/g43t-am3/early_init.c:
https://review.coreboot.org/c/coreboot/+/57764/comment/2241918c_8e6ea6d3?usp... :
PS4, Line 4: #include <southbridge/intel/i82801jx/i82801jx.h>
looks like this one is not used.
Unrelated to this patch. It only reworks the mainboard that variants can be used. Clean ups can be done later. Done.
https://review.coreboot.org/c/coreboot/+/57764/comment/01c18252_1308236a?usp... :
PS4, Line 7: #include <superio/ite/it8720f/it8720f.h>
this is not used.
Unrelated to this patch. It only reworks the mainboard that variants can be used. Clean ups can be done later. Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57764?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I425852f4bdacf7cb6688a5fb845ac3001373262e
Gerrit-Change-Number: 57764
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Julia
launchpad.vineyard395@passinbox.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julia
launchpad.vineyard395@passinbox.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Michael Büchler
michael.buechler@posteo.net
Gerrit-Comment-Date: Sun, 18 Aug 2024 10:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr