[coreboot-gerrit] Change in coreboot[master]: mb/siemens/mc_apl{3,5}: Remove __weak symbol from GPIO functions

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36094 )

Change subject: mb/siemens/mc_apl{3,5}: Remove __weak symbol from GPIO functions
......................................................................

mb/siemens/mc_apl{3,5}: Remove __weak symbol from GPIO functions

The two GPIO functions variant_gpio_table() and
variant_early_gpio_table() provide the pointer to the variants GPIO
table for late and early GPIO init. As these functions are variant
dependent the keyword __weak must not be used as otherwise the linker
might choose the tables from the baseboard.
This patch removes the __weak definition making these functions
overriding the general ones in baseboard/gpio.c.

Change-Id: Ic7fc816d40cb112d7ab51089c3962a77798c08a8
Signed-off-by: Werner Zeh 
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c
M src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c
2 files changed, 4 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/36094/1

diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c
index e0fec7c..7401c74 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/gpio.c
@@ -363,7 +363,7 @@
    PAD_CFG_NF(SVID0_CLK, UP_20K, DEEP, NF1),	/* SVID0_CLK */
 };

-const struct pad_config *__weak variant_gpio_table(size_t *num)
+const struct pad_config *variant_gpio_table(size_t *num)
 {
    *num = ARRAY_SIZE(gpio_table);
    return gpio_table;
@@ -406,8 +406,7 @@
    PAD_CFG_NF(LPC_FRAMEB, NONE, DEEP, NF1),	/* LPC_FRAME_N */
 };

-const struct pad_config *__weak
-variant_early_gpio_table(size_t *num)
+const struct pad_config *variant_early_gpio_table(size_t *num)
 {
    *num = ARRAY_SIZE(early_gpio_table);
    return early_gpio_table;
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c
index f6578cb..3edf14f 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl5/gpio.c
@@ -363,7 +363,7 @@
    PAD_CFG_NF(SVID0_CLK, UP_20K, DEEP, NF1),	/* SVID0_CLK */
 };

-const struct pad_config *__weak variant_gpio_table(size_t *num)
+const struct pad_config *variant_gpio_table(size_t *num)
 {
    *num = ARRAY_SIZE(gpio_table);
    return gpio_table;
@@ -409,8 +409,7 @@
    PAD_CFG_GPO(PMIC_STDBY, 0, DEEP),
 };

-const struct pad_config *__weak
-variant_early_gpio_table(size_t *num)
+const struct pad_config *variant_early_gpio_table(size_t *num)
 {
    *num = ARRAY_SIZE(early_gpio_table);
    return early_gpio_table;