[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common/spi: Properly check if setting FRP succeeded

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33389 )

Change subject: sb/intel/common/spi: Properly check if setting FRP succeeded
......................................................................

sb/intel/common/spi: Properly check if setting FRP succeeded

Change-Id: Ib0b63c3b0342c62aeabb5c6e418eb9811fc6597d
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33389
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
---
M src/southbridge/intel/common/spi.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved

diff --git a/src/southbridge/intel/common/spi.c b/src/southbridge/intel/common/spi.c
index d9a77c3..e8c8f01 100644
--- a/src/southbridge/intel/common/spi.c
+++ b/src/southbridge/intel/common/spi.c
@@ -1038,8 +1038,7 @@

/* Set the FPR register and verify it is protected */
    write32(&fpr_base[fpr], reg);
-	reg = read32(&fpr_base[fpr]);
-	if (!(reg & protect_mask)) {
+	if (reg != read32(&fpr_base[fpr])) {
    	printk(BIOS_ERR, "ERROR: Unable to set SPI FPR %d\n", fpr);
    	return -1;
    }