Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35188 )
Change subject: soc/skylake: lock aesni msr
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35188/4/src/soc/intel/skylake/cpu.c
File src/soc/intel/skylake/cpu.c:
https://review.coreboot.org/c/coreboot/+/35188/4/src/soc/intel/skylake/cpu.c...
PS4, Line 429: /* Lock it */
This comment is really obnoxious... […]
... copied from somewhere below, you can find that multiple times in that file;) Maybe something like "Lock it because the datasheet says so" or "Lock it to prevent unintended disabling" ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97a0d3b1b9b0452e929ca07d29c03237b413e521
Gerrit-Change-Number: 35188
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 01 Sep 2019 23:07:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment