Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41760 )
Change subject: intel/fsp2_0: Add functions for adding Intel FSP version to coreboot table ......................................................................
Patch Set 12:
(3 comments)
Patch Set 11:
(2 comments)
I do not see, why this should be configurable by a Kconfig option. I’d always add the FSP version to the coreboot tables.
Removed the new Kconfig option, it applies when PLATFORM_USES_FSP2_0 is selected. Move functions here so coreboot_table.c in CB:41809 can avoid using #if preprocessing.
https://review.coreboot.org/c/coreboot/+/41760/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41760/11//COMMIT_MSG@11 PS11, Line 11:
can u please add a test and sample string what u read using this API.
Done
https://review.coreboot.org/c/coreboot/+/41760/11/src/drivers/intel/fsp2_0/K... File src/drivers/intel/fsp2_0/Kconfig:
PS11:
The Kconfig addition should probably go into the next commit?
Done
https://review.coreboot.org/c/coreboot/+/41760/11/src/drivers/intel/fsp2_0/K... PS11, Line 213: cbmem
What does CBMEM have to do with coreboot tables?
I meant the cbmem utility. I removed this option and this feature applies when PLATFORM_USES_FSP2_0 is selected.