Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83558?usp=email )
Change subject: soc/intel/cnvi: Add SOW to ensure CNVi isn't put into D3 Cold
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File src/soc/intel/common/block/cnvi/cnvi.c:
https://review.coreboot.org/c/coreboot/+/83558/comment/adab2463_d18f051d?usp... :
PS8, Line 97: /*
maybe add a comment here that the '3' is limiting it to D3 Hot?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83558?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1541cebc022adc927a9cd883500320e9ef82359f
Gerrit-Change-Number: 83558
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Fri, 02 Aug 2024 13:52:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes