Attention is currently required from: Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59660 )
Change subject: oprom/realmode/x86.c: Fix building for ENV_X86_64
......................................................................
Patch Set 3: Verified+1
(2 comments)
File src/device/oprom/realmode/x86.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134674):
https://review.coreboot.org/c/coreboot/+/59660/comment/7238f025_e7fce986
PS3, Line 94: .rip=X86_EIP,
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134674):
https://review.coreboot.org/c/coreboot/+/59660/comment/e32904ea_3bfa8095
PS3, Line 100: .rflags=X86_EFLAGS
spaces required around that '=' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ce8d56da326aeff5ff9b400ded02d4309372519
Gerrit-Change-Number: 59660
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subi.banik@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 30 Nov 2021 18:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment