Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71712 )
Change subject: post_codes: Add an optional "Prefix" to post codes sent to IO ......................................................................
Patch Set 1:
(6 comments)
File src/console/Kconfig:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167783): https://review.coreboot.org/c/coreboot/+/71712/comment/5502bb33_0996fbfe PS1, Line 539: hex "POST code identifer value" 'identifer' may be misspelled - perhaps 'identifier'?
File src/include/cpu/x86/post_code.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167783): https://review.coreboot.org/c/coreboot/+/71712/comment/0e7ae03a_451b6184 PS1, Line 10: #define post_code(value) \ Macros with multiple statements should be enclosed in a do - while loop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167783): https://review.coreboot.org/c/coreboot/+/71712/comment/839dbc39_b88d5fa0 PS1, Line 11: movb $CONFIG_POST_CODE_IDENTIFIER_VALUE, %al; \ need consistent spacing around '%' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167783): https://review.coreboot.org/c/coreboot/+/71712/comment/351e04f6_006696ca PS1, Line 12: outb %al, $CONFIG_POST_IO_PORT; \ need consistent spacing around '%' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167783): https://review.coreboot.org/c/coreboot/+/71712/comment/2acbbeff_eb6df07c PS1, Line 13: movb $value, %al; \ need consistent spacing around '%' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167783): https://review.coreboot.org/c/coreboot/+/71712/comment/d5e5fb99_f4a50bc0 PS1, Line 14: outb %al, $CONFIG_POST_IO_PORT need consistent spacing around '%' (ctx:WxV)