Attention is currently required from: Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51476 )
Change subject: soc/amd/picasso/mca: fix core MCA bank names
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/picasso/mca.c:
https://review.coreboot.org/c/coreboot/+/51476/comment/70fc4798_e030b993
PS3, Line 140: "Decode unit"
Missing a comma after this one? I'd suggest using designated array initializers:
static const char *const mca_bank_name[] = {
[0] = "Load-store unit",
[1] = "Instruction fetch unit",
[2] = "L2 cache unit",
[3] = "Decode unit",
[4] = "",
[5] = "Execution unit",
[6] = "Floating point unit",
[7] = "L3 cache unit",
};
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia86cf3874f8b16b007bad46535af6dafb776fbdd
Gerrit-Change-Number: 51476
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 25 Mar 2021 10:22:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment