Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )
Change subject: security/vboot: Add vboot callbacks to support EC software sync ......................................................................
Patch Set 15:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/Kconfig... PS15, Line 236: is already : currently performed later in the boot flow.
will be performed later in the boot flow if it is disabled here.
Done
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/ec_sync... File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/ec_sync... PS15, Line 26:
nit: why?
Auto-indent :) Changed back.
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/ec_sync... PS15, Line 267: burst = (pdata_max_size - sizeof(*params)) - sizeof(struct ec_host_request);
Well, you're throwing away a bit of stack space here now. […]
Yeah that's true. Updated.
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/ec_sync... PS15, Line 295: file_buf += todo;
This doesn't do anything anymore now (in fact it would probably break the munmap() below on a platfo […]
Done
https://review.coreboot.org/c/coreboot/+/36208/15/src/security/vboot/ec_sync... PS15, Line 301: todo += sizeof(struct ec_params_flash_write);
nit: This just threw me for a loop a bit, I think it would be easier to follow if you just write 'si […]
Done