Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55973 )
Change subject: util/cbfstool: Allow setting alignment for payload
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Is that new? I was getting something that wasn't 64 byte aligned, hence this CL.
Oh wait, sorry, I confused myself about how stuff works again. CBFS file *entries* have a minimum alignment of 64. What you care about is CBFS file *data*, and for that the minimum alignment is 4 (I think?). So you do need -a 64. Sorry. Carry on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55973
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f4aea5f0cbeaa8e761212041099b37f4718ac39
Gerrit-Change-Number: 55973
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 09 Jul 2021 23:37:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment