[coreboot-gerrit] Change in coreboot[master]: mb/google/hatch: Refactor override_early_gpio_table

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34782 )

Change subject: mb/google/hatch: Refactor override_early_gpio_table
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34782/4/src/mainboard/google/hatch/... 
File src/mainboard/google/hatch/variants/hatch/gpio.c:

https://review.coreboot.org/c/coreboot/+/34782/4/src/mainboard/google/hatch/... 
PS4, Line 56: 	PAD_CFG_GPI(GPP_F2, NONE, PLTRST),
> I think we need configure memory strap pins correctly in the early_gpio_table.

Yes, I removed them because they are configured in platform-specific code.  I don't see a good reason to configure them two times in two different places, it is confusing and unexpected behavior.  I would vote either keep them in this table and not reconfigure them later (i.e., don't use gpio_base2_value(), and just directly use gpio_input()), or drop them from the table and add a comment as to the behavior in hatch's romstage.  Thoughts?