Attention is currently required from: Malik Hsu, Tim Wawrzynczak.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59135 )
Change subject: mb/google/brya/variants/primus: enable RTD3 for PCIe-eMMC bridge
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
https://review.coreboot.org/c/coreboot/+/59135/comment/71f51dce_ebd745fa
PS3, Line 25: if (board_ver > 1)
: return;
i think you can move this check to the line 15. Return immediately if the board doesn't need this modification.
https://review.coreboot.org/c/coreboot/+/59135/comment/8f9bdade_d26c9f9a
PS3, Line 33: uint32_t board_ver = board_id();
I would suggest to put this line to the function devtree_update_emmc_rtd3()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59135
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5836d65cedfe3907af2c4c33de7a396c4bb8b727
Gerrit-Change-Number: 59135
Gerrit-PatchSet: 3
Gerrit-Owner: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Attention: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 11 Nov 2021 02:45:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment