Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Is device/ the right place for this? I guess it's the first time
we put chip-specific configuration there.
Also, this looks like it's only used optionally in case we want
to bring up a framebuffer early. Is that correct? That's definitely
a driver then and not necessary initialization in coreboot. (I have
this weird idea in mind that drivers/ should be split up into things
that do necessary initialization and actual drivers that allow
the firmware itself to use a piece of hardware).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 21 Aug 2021 08:56:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment