Attention is currently required from: Keith Hui, Keith Hui, Riku Viitanen.
Felix Singer has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/79545?usp=email )
Change subject: mb/hp: Move compaq_8200_elite_sff_pc into snb_ivb_desktops variants
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/hp/snb_ivb_desktops/variants/compaq_8200_elite_sff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79545/comment/aa6459b8_f3651a05?usp... :
PS2, Line 9: register "spi_uvscc" = "0x0"
You tested to still boot, so looks like you have the hardware. […]
It's just a copy from the original devicetree and it's equal to not setting it at all. Let's ignore it for now, but it would be nice to clean it up later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79545?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03d57c7e76ccdfccd58b2a6deab4dee87b02503a
Gerrit-Change-Number: 79545
Gerrit-PatchSet: 3
Gerrit-Owner: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-Attention: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Mon, 26 Aug 2024 22:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Riku Viitanen
riku.viitanen@protonmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com