Attention is currently required from: Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84003?usp=email )
Change subject: Add initial experimental LTO support
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/84003/comment/78219dcb_e752ec20?usp... :
PS2, Line 551: CFLAGS_common += -flto
Have you tried this with ADAFLAGS_common?
https://review.coreboot.org/c/coreboot/+/84003/comment/b1aedc91_7f8bc56f?usp... :
PS2, Line 1329: @printf " LINK $$(subst $$(obj)/,,$$(@))\n"
Technically, you could move the first two lines out of the `ifeq`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84003?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Gerrit-Change-Number: 84003
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marvin Drees
marvin.drees@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 21 Aug 2024 09:22:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes