Attention is currently required from: Bill XIE, Paul Menzel.
Hello build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Lean Sheng Tan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69215
to look at the new patch set (#5).
Change subject: cpu/x86/mp_init.c: Handle dummy nodes in cpu bus ......................................................................
cpu/x86/mp_init.c: Handle dummy nodes in cpu bus
commit 48c825ebd1beadb8ac4fd3ae687a36ff4705ab7a assumes that (g_)cpu_bus->children->sibling represents the first AP cpu, but this is not true when device tree (like mb/asus/p8x7x-series/devicetree.cb) contains static dummy lapic nodes. In such case, Linux kernel can find one cpu unable to wake up, and an additional working cpu without corresponding ACPI firmware node:
smpboot: Allowing 5 CPUs, 0 hotplug CPUs smpboot: CPU0: Intel(R) Xeon(R) CPU E3-1225 V2 @ 3.20GHz (family: 0x6, model: 0x3a, stepping: 0x9) smpboot: do_boot_cpu failed(-1) to wakeup CPU#2
This could be resolved by skipping disabled cpu nodes.
Signed-off-by: Bill XIE persmule@hardenedlinux.org Change-Id: I1075bc52091e619ef79cbeab0a0f6b57cff1d708 --- M src/cpu/x86/mp_init.c 1 file changed, 31 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/69215/5