24 Jun
2023
24 Jun
'23
4:22 a.m.
Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76009?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: acpi/Makefile.inc: Conditionally include X86 specific code ......................................................................
Patch Set 1:
(1 comment)
File src/acpi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76009/comment/0166c059_fa4a00b3 : PS1, Line 8: ramstage-$(CONFIG_ARCH_X86) += acpi_hpet.c Do we need this form?
src/arch/x86/Makefile.inc: ifeq ($(CONFIG_ARCH_RAMSTAGE_X86_32)$(CONFIG_ARCH_RAMSTAGE_X86_64),y)
--
To view, visit https://review.coreboot.org/c/coreboot/+/76009?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63bbac225662377693ad5f29cc8911494c49b422
Gerrit-Change-Number: 76009
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 24 Jun 2023 04:22:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment