Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42489 )
Change subject: ACPI: Drop typedef global_nvs_t
......................................................................
Patch Set 6:
Patch Set 6: Code-Review+1
so ~99% of the change is removing the typedef, but there's some introduction of new APIs in there (acpi_create_gnvs ...). Is that intentional or did these slip in?
Commit message says it all? At least for acpi_create_gnvs() there was mixture of static and non-static function definitions. I may have not pushed all the work yet, but both acpi_create_gnvs() and acpi_init_gnvs() would be gone at the very end.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4299c41d79c228f3d35bc7cb9bf427ce1e82ba1
Gerrit-Change-Number: 42489
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 05:58:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment