[coreboot-gerrit] [M] Change in coreboot[master]: soc/qualcomm/sc7280: Add socinfo_pro_part() function in coreboot

[Julius Werner (Code Review)]

Attention is currently required from: Shelley Chen, Taniya Das, Venkat Thogaru, Sudheer Amrabadi.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68384 )

Change subject: soc/qualcomm/sc7280: Add  socinfo_pro_part() function in coreboot
......................................................................

Patch Set 6:

(3 comments)

File src/soc/qualcomm/sc7280/include/soc/socinfo.h:

https://review.coreboot.org/c/coreboot/+/68384/comment/a9b025f4_15cfe1d9 
PS6, Line 53: 	uint16_t jtagid;
This could still be
```
uint16_t chipid;
uint16_t jtagid : 14;
uint16_t modem  :  1;
uint16_t pro    :  1;
```
for further size reduction, even if you need to keep chipid.

File src/soc/qualcomm/sc7280/socinfo.c:

https://review.coreboot.org/c/coreboot/+/68384/comment/240cf3bb_90a98b86 
PS4, Line 12: static struct chipinfo chipinfolut[] = {
> Changed structure members range uint32_t to uint16_t, in structure initialization instead of macros  […]

Can you clarify what future purpose? Where are we going to need these?

File src/soc/qualcomm/sc7280/socinfo.c:

https://review.coreboot.org/c/coreboot/+/68384/comment/d6a5266b_c144d97e 
PS6, Line 53: 	for (i = 0; i < ARRAY_SIZE(chipinfolut); i++)
The lookup part for both of these could be factored out into a helper function.