Attention is currently required from: Paul Menzel, Tim Wawrzynczak.
Shon Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61033 )
Change subject: mb/google/brya/var/vell: update gpio for DMIC
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61033/comment/35f8c699_df5ec8d8
PS2, Line 11:
Why?
Done
File src/mainboard/google/brya/variants/vell/gpio.c:
https://review.coreboot.org/c/coreboot/+/61033/comment/f15274b5_cac942fa
PS2, Line 65: /* R6 : NC */
: PAD_NC(GPP_R6, NONE),
: /* R7 : NC */
: PAD_NC(GPP_R7, NONE),
intel team still check […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61033
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b5ccd2c239e526e4f1ce2d5ed6c1386303590c8
Gerrit-Change-Number: 61033
Gerrit-PatchSet: 3
Gerrit-Owner: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
coreboot.test@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 10 Feb 2022 06:47:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-MessageType: comment