Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84026?usp=email )
Change subject: soc/mediatek/mt8196: Add EINT support ......................................................................
Patch Set 8:
(2 comments)
File src/soc/mediatek/mt8196/eint.c:
https://review.coreboot.org/c/coreboot/+/84026/comment/a60fb5d4_57cb1d16?usp... : PS8, Line 11: [4] Use a struct: ``` struct eint_info { uintptr_t base; // How about storing EINT_E_BASE directly? uint32_t index; uint32_t debounce; // Is this unused? }; ```
Note that `eint_num` is not needed, because we are already using it as the array index.
https://review.coreboot.org/c/coreboot/+/84026/comment/ea41aa6a_8029ae23?usp... : PS8, Line 13: {0, 2, 0, 1}, Can we put one entry `{a, b, c, d}` per line?