Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83928?usp=email )
Change subject: soc/mediatek/mt8196: Fix timer reset in BL31 ......................................................................
Patch Set 23:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83928/comment/254fc1fa_33a356c0?usp... : PS23, Line 9: 1. Set systimer compensation to version 2.0. : 2. Remove
File src/soc/mediatek/mt8196/timer_prepare.c:
https://review.coreboot.org/c/coreboot/+/83928/comment/12b8e596_2a19ccca?usp... : PS23, Line 18: write32 `WRITE32_BITFIELDS`
https://review.coreboot.org/c/coreboot/+/83928/comment/98a69076_0becd0c3?usp... : PS23, Line 23: setbits32 `SET32_BITFIELDS`
https://review.coreboot.org/c/coreboot/+/83928/comment/c0acd304_242cdc26?usp... : PS23, Line 28: const No need for `const`.
https://review.coreboot.org/c/coreboot/+/83928/comment/60ca2c1a_365a9d07?usp... : PS23, Line 30: clrsetbits32p Please use `SET32_BITFIELDS` as suggested by Hung-Te.