Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63625 )
Change subject: soc/intel/cmn/fast_spi: Add API to clear outstanding SPI status
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/63625/comment/875c1688_35debe4c
PS6, Line 437: SPIBAR_HSFSTS_W1C_BITS
I must admitt that Elkhart Lake does define bit 8 as well. Sorry for overseeing it.
how about making is a word width ? actually BIOS_HSFSTS_CTL (offset 0x4) has two part as in LSB is HSFSTS and MSB is HSFCTL. In that case 0xFFFF would serve best IMO.
WDYT?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63625
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62adba0d0cef1d4c53b24800f90b4fe76a9d78b7
Gerrit-Change-Number: 63625
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 22 Apr 2022 07:33:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment