Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42062 )
Change subject: src/*: Update makefiles to exclude x86 code from psp-verstage ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/42062/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/4/Makefile.inc@616 PS4, Line 616: : ifeq ($(CONFIG_ARCH_VERSTAGE_X86_32)$(CONFIG_ARCH_VERSTAGE_X86_64),y) : verstage-y += $(verstage-x86_32_64-y) : endif Left over from an earlier version. Will remove.
https://review.coreboot.org/c/coreboot/+/42062/6/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/6/Makefile.inc@104 PS6, Line 104: x86_verstage
Can you do verstage_x86 instead? I'm assuming you will add a verstage_arm next.
Sure, I can update it.
I'm not planning on doing a verstage_arm class. There's no need for it yet.
https://review.coreboot.org/c/coreboot/+/42062/3/src/drivers/pc80/pc/Makefil... File src/drivers/pc80/pc/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/drivers/pc80/pc/Makefil... PS3, Line 11: verstage-y += i8254.c
Ya. That sounds like a good solution.
Done
https://review.coreboot.org/c/coreboot/+/42062/3/src/lib/Makefile.inc File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/lib/Makefile.inc@50 PS3, Line 50: verstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c
Yeah, this is temporary. I can add a TODO to remove it once I have the timestamps implemented.
Moved to a different commit with a TODO added.
https://review.coreboot.org/c/coreboot/+/42062/4/src/soc/amd/common/block/al... File src/soc/amd/common/block/alink/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/4/src/soc/amd/common/block/al... PS4, Line 2: $(eval $(call verstage-x86,$(CONFIG_SOC_AMD_COMMON_BLOCK_ALINK),alink.c)) Didn't get updated with the latest version.
https://review.coreboot.org/c/coreboot/+/42062/3/src/soc/amd/common/block/pc... File src/soc/amd/common/block/pci/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/42062/3/src/soc/amd/common/block/pc... PS3, Line 4:
Agreed, but I think we should probably split this into two directories or control it with two separa […]
Fixed just in this directory for now.