Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39979 )
Change subject: intel/xeon_sp: add ACPI to control GPIO ......................................................................
Patch Set 40:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39979/40/src/soc/intel/xeon_sp/acpi... File src/soc/intel/xeon_sp/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/39979/40/src/soc/intel/xeon_sp/acpi... PS40, Line 126: Case (COMM_2) { : Local0 = PID_GPIOCOM2 Community 3? Actually Community 2 is listed in EDS. But we would better to follow implementation in kernel.