Attention is currently required from: Jakub Czapiga.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80122?usp=email )
Change subject: tests: Rename Makefiles from .inc to .mak ......................................................................
tests: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: Id09eafd293a54198aab87281f529749325df8b07 --- M tests/Makefile.common M tests/Makefile.mak R tests/acpi/Makefile.mak R tests/commonlib/Makefile.mak R tests/commonlib/bsd/Makefile.mak R tests/console/Makefile.mak R tests/device/Makefile.mak R tests/drivers/Makefile.mak R tests/lib/Makefile.mak 9 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/80122/1
diff --git a/tests/Makefile.common b/tests/Makefile.common index e51d253..d64053b 100644 --- a/tests/Makefile.common +++ b/tests/Makefile.common @@ -42,7 +42,7 @@ TEST_INCLUDES += -I$(dir $(TEST_KCONFIG_AUTOHEADER))
# Note: This is intentionally just a subset of the warnings in the toplevel -# Makefile.inc. We don't need to be as strict with test code, and things like +# Makefile.mak. We don't need to be as strict with test code, and things like # -Wmissing-prototypes just make working with the test framework cumbersome. # Only put conservative warnings here that really detect code that's obviously # unintentional. @@ -95,7 +95,7 @@ $(1)-config-file := $(testobj)/$(1)/config.h $$($(1)-config-file): $(TEST_KCONFIG_AUTOHEADER) mkdir -p $$(dir $$@) - printf '// File generated by tests/Makefile.inc\n// Do not change\n' > $$@ + printf '// File generated by tests/Makefile.mak\n// Do not change\n' > $$@ printf '#include <%s>\n\n' "$(notdir $(TEST_KCONFIG_AUTOHEADER))" >> $$@ for kv in $$($(1)-config); do \ key="`echo $$$$kv | cut -d '=' -f -1`"; \ diff --git a/tests/Makefile.mak b/tests/Makefile.mak index 584b4c0..10d3326 100644 --- a/tests/Makefile.mak +++ b/tests/Makefile.mak @@ -44,7 +44,7 @@ $(eval $(1)$(2)-stage := $(if $($(1)$(2)-stage),$($(1)$(2)-stage),ramstage)) $(if $(findstring $($(1)$(2)-stage), $(stages)),, $(error Wrong $(1)$(2)-stage value $($(1)$(2)-stage). \ - Check your $(dir $(1)$(2))Makefile.inc)) + Check your $(dir $(1)$(2))Makefile.mak)) endef
$(call add-special-class, tests) diff --git a/tests/acpi/Makefile.inc b/tests/acpi/Makefile.mak similarity index 100% rename from tests/acpi/Makefile.inc rename to tests/acpi/Makefile.mak diff --git a/tests/commonlib/Makefile.inc b/tests/commonlib/Makefile.mak similarity index 100% rename from tests/commonlib/Makefile.inc rename to tests/commonlib/Makefile.mak diff --git a/tests/commonlib/bsd/Makefile.inc b/tests/commonlib/bsd/Makefile.mak similarity index 100% rename from tests/commonlib/bsd/Makefile.inc rename to tests/commonlib/bsd/Makefile.mak diff --git a/tests/console/Makefile.inc b/tests/console/Makefile.mak similarity index 100% rename from tests/console/Makefile.inc rename to tests/console/Makefile.mak diff --git a/tests/device/Makefile.inc b/tests/device/Makefile.mak similarity index 100% rename from tests/device/Makefile.inc rename to tests/device/Makefile.mak diff --git a/tests/drivers/Makefile.inc b/tests/drivers/Makefile.mak similarity index 100% rename from tests/drivers/Makefile.inc rename to tests/drivers/Makefile.mak diff --git a/tests/lib/Makefile.inc b/tests/lib/Makefile.mak similarity index 100% rename from tests/lib/Makefile.inc rename to tests/lib/Makefile.mak