Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40278 )
Change subject: mb/purism/librem_whl: Add new board Librem Mini (WHL-U) ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40278/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40278/8//COMMIT_MSG@14 PS8, Line 14: UDP
UPD
Done
https://review.coreboot.org/c/coreboot/+/40278/8/src/mainboard/purism/librem... File src/mainboard/purism/librem_whl/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/40278/8/src/mainboard/purism/librem... PS8, Line 3: {
nit: this should go on the next line (if this is needed at all)
Done
https://review.coreboot.org/c/coreboot/+/40278/8/src/mainboard/purism/librem... File src/mainboard/purism/librem_whl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40278/8/src/mainboard/purism/librem... PS8, Line 96: Type-A front left upper
You might consider describing these ports in the ACPI XHCI config as well, having the kernel report […]
thanks, added the port descriptions. I'll have to see about the port wake, but appreciate the heads up :)
https://review.coreboot.org/c/coreboot/+/40278/8/src/mainboard/purism/librem... PS8, Line 136: AcousticNoiseMitigation
I think enabling this without any of the related settings (slew rates) isn't going to do anything.
good note. Is there an easy way to determine these? The AMI firmware had an enable/disable option (defaulting to enabled, which is why I did) but no exposed slew rates etc.