Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli.
Sukumar Ghorai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75814?usp=email )
Change subject: src/soc/intel/meteorlake: disable acpi timer for xtal shutdown
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/75814/comment/96ecb599_c5fa352d :
PS1, Line 619: 0
we don't need to set this UPD. […]
PMC MMIO + offset 0x18FC : disable ACPI driver is working fine for SoC-PMC.
We need the similar settings for IOE-PMC.
Hence best solution is to disable from FSP parameter.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75814?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b5f8f6647364d967ed96c45fe5a9d55fdc8a2c7
Gerrit-Change-Number: 75814
Gerrit-PatchSet: 1
Gerrit-Owner: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 14 Jun 2023 15:23:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment