Attention is currently required from: Felix Held.
Hello build bot (Jenkins), coreboot org,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74619?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+2 by coreboot org
Change subject: include/cpu/amd/mtrr: rename TOP_MEM(2) and remove workaround ......................................................................
include/cpu/amd/mtrr: rename TOP_MEM(2) and remove workaround
Both AGESA.h and cpu/amd/mtrr.h defined TOP_MEM and TOP_MEM2, but since it was defined as unsigned long in AGESA.h, a workaround was needed in cpu/amd/mtrr.h to not have the build fail due to a non-identical redefinition of TOP_MEM and TOP_MEM2. Just removing the workaround without reaming the defines isn't trivially possible, since the stoneyridge romstage.c still ends up including both definitions which can't be easily worked around. Now all non-vendorcode coreboot code uses TOP_MEM_MSR and TOP_MEM2_MSR while the vendorcode part uses TOP_MEM and TOP_MEM2 to avoid this.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ibad72dac17bd0b05734709d42c6802b7c8a87455 --- M src/drivers/amd/agesa/s3_mtrr.c M src/include/cpu/amd/mtrr.h 2 files changed, 6 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/74619/2