Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31762 )
Change subject: arch/x86/postcar: Add separate timestamp for postcar stage
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31762/1/src/arch/x86/postcar_loader.c
File src/arch/x86/postcar_loader.c:
https://review.coreboot.org/#/c/31762/1/src/arch/x86/postcar_loader.c@178
PS1, Line 178: timestamp_add_now(TS_START_POSTCAR);
But that makes things inconsistent. […]
you should comment/document such notions.
I will add some comment to note that point.
new timestamp that is essentially "about to start" vs "actually started", but we can read between the lines as to what is happening there.
I will name may be "Starting of postcar" and "end of postcar" to make thinks consistent across ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I084f66949667ad598f811d4233b4e639bc4c113e
Gerrit-Change-Number: 31762
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 05 Mar 2019 17:35:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment