[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell: Move LPE ACPI code to mainboard

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29414 )

Change subject: soc/intel/braswell: Move LPE ACPI code to mainboard
......................................................................

Patch Set 12: Code-Review+2

(3 comments)

https://review.coreboot.org/#/c/29414/11//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/29414/11//COMMIT_MSG@12 
PS11, Line 12: LPE enabled.
> I still miss the information that this works around an […]

Done

https://review.coreboot.org/#/c/29414/10/src/mainboard/google/cyan/dsdt.asl 
File src/mainboard/google/cyan/dsdt.asl:

https://review.coreboot.org/#/c/29414/10/src/mainboard/google/cyan/dsdt.asl@... 
PS10, Line 7:  * Copyright (C) 2019 Eltan B.V.
> Is this contribution really worth adding a copyright line?  Is it a "Creative and significant" contr […]

Done

https://review.coreboot.org/#/c/29414/8/src/soc/intel/braswell/acpi/southclu... 
File src/soc/intel/braswell/acpi/southcluster.asl:

https://review.coreboot.org/#/c/29414/8/src/soc/intel/braswell/acpi/southclu... 
PS8, Line 291:
> This issue can be solved different ways. […]

Ack