Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44890 )
Change subject: mb/google/zork/trembyle: move PCIe GPP clock setting to devicetree
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44890/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44890/1//COMMIT_MSG@8
PS1, Line 8:
You should probably describe why you're pulling those values from the descriptors. […]
seems like those shouldn't be dropped from the descriptor, since that will affect other registers as well. I'll have a closer look
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3fc83484c6ce769956dc8e6e57194ffebb4f5b0
Gerrit-Change-Number: 44890
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 28 Aug 2020 12:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment