Attention is currently required from: Martin Roth, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52680 )
Change subject: mb/google/guybrush: Set system_config to 2 for guybrush boards
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52680/comment/9220166a_c73deeb2
PS1, Line 9: system_config
Nit: Use the longer term here: system_configuration?
https://review.coreboot.org/c/coreboot/+/52680/comment/aae7a3ab_3cf2e721
PS1, Line 11:
What bug does this fix? Besides the FSP UPD I didn’t find anything in the source.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52680
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ce2acb3b4ed51aa9a0aa379ed125f0b04f04d31
Gerrit-Change-Number: 52680
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 29 Apr 2021 05:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment