Attention is currently required from: David Hendricks, Elyes Haouas, Jonathan Zhang, Martin L Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68593?usp=email )
Change subject: acpi/Kconfig: Move unused ACPI_EINJ config option to vendorcode
......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68593/comment/555a43f1_b4c3f66f :
PS10, Line 7: Move unused ACPI_EINJ config option to vendorcode
Maybe:
Move ACPI Error Injection Table option to OCP vendorcode
https://review.coreboot.org/c/coreboot/+/68593/comment/66cd8e7d_71a0061c :
PS10, Line 9: There is no code behind ACPI_EINJ because there is IP sensitive code
: involved in the flow.
Do you have more information on that? Error Injection Table sounds pretty generic. If it’s vendor specific, it should be namespaced.
https://review.coreboot.org/c/coreboot/+/68593/comment/ed447270_a61b515b :
PS10, Line 11: ACPI_EINJ is used in silicon vendors development, so move it to
Please add one blank line between paragraphs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68593?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I222478572a9e5efadd6719a164558833298e4c99
Gerrit-Change-Number: 68593
Gerrit-PatchSet: 10
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 03 Aug 2023 07:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment