Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31685 )
Change subject: device/pci_ops: Reuse romstage PCI config for ramstage
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31685/5/src/include/device/pci_type.h
File src/include/device/pci_type.h:
https://review.coreboot.org/#/c/31685/5/src/include/device/pci_type.h@32
PS5, Line 32: * the check themselves.
Going thru assert() retains behaviour to parent commit and is not a regression per-se.
Oh, right, must have mixed changes up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9364cb34fe8127972c772516a0a0b1d281c5ed00
Gerrit-Change-Number: 31685
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 13 Mar 2019 14:20:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment