Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31887 )
Change subject: vboot: make vboot_working_data available to payload ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31887/1/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/#/c/31887/1/src/lib/coreboot_table.c@46 PS1, Line 46: #if CONFIG(VBOOT) don't conditionally include this bit. It should be able to be unconditionally included.
https://review.coreboot.org/#/c/31887/1/src/lib/coreboot_table.c@562 PS1, Line 562: lb_vboot_wd(head); This shouldn't be within #if CHROMEOS. It should be based on if (CONFIG(VBOOT)) -- c runtime.
https://review.coreboot.org/#/c/31887/1/src/security/vboot/misc.h File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/31887/1/src/security/vboot/misc.h@39 PS1, Line 39: uint32_t buffer_size; This size field should be documented for what it represents. Full size of area from start of struct?