Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40645 )
Change subject: src/lib: Enable SPD_READ_BY_WORD by default ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40645/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40645/3//COMMIT_MSG@10 PS3, Line 10: 68,613ns for each PAGE. I think comma here is just confusing, is it a thousands or decimals separator? Unit does not look right to me either.
https://review.coreboot.org/c/coreboot/+/40645/2/src/soc/intel/common/block/... File src/soc/intel/common/block/smbus/Kconfig:
https://review.coreboot.org/c/coreboot/+/40645/2/src/soc/intel/common/block/... PS2, Line 3: select SPD_READ_BY_WORD
I think this can be enabled for all boards. And this is only for SPD read not all SMBus read. […]
I checked SDRAM SPD specs from 1999 and it already specified EEPROM sequential read with unlimited byte count. Word read is case of sequential read with byte count of two, so this should be fine.
AFAIR one SPD specification for a memory technology (eg. SDRAM, DDR2, DDR4) always covers the different physical module types.