Attention is currently required from: Hung-Te Lin, Knox Chiou, Yang Wu, Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Make compatible with MT8186T by modifing skuid
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84342/comment/26147984_cc6cf993?usp... :
PS2, Line 10: corresponded
corresponding
https://review.coreboot.org/c/coreboot/+/84342/comment/0f683fa8_8940d4fe?usp... :
PS2, Line 15: 1.Pre-flashed 0x7fffffff and boot OS.
: 2.Check OS boot normally by 0x7ffffffe.
It’d be great if you put a space after the “bullet”.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Knox Chiou
knoxchiou@google.com
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Knox Chiou
knoxchiou@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Sat, 14 Sep 2024 06:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No