7 Mar
2022
7 Mar
'22
5:26 p.m.
Attention is currently required from: Felix Singer, Jeff Daly, Martin Roth, Paul Menzel, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60877 )
Change subject: sb/intel/common/firmware: Hook up adding 10GbE LAN firmware ......................................................................
Patch Set 16: Code-Review+2
(1 comment)
File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/60877/comment/ac2f95c1_266efe60 PS16, Line 168: depends on MAINBOARD_USES_IFD_10GBE_0_REGION
this is in order to ensure no misconfiguration by an unknowing/careless developer. […]
Ah, I see. Thanks for the detailed explanation.
--
To view, visit https://review.coreboot.org/c/coreboot/+/60877
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id45ab4b69a85a5f8e52c0c4b130b6d729222b4c3
Gerrit-Change-Number: 60877
Gerrit-PatchSet: 16
Gerrit-Owner: Jeff Daly jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Jeff Daly jeffd@silicom-usa.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 17:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jeff Daly jeffd@silicom-usa.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment