Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43743 )
Change subject: nb/intel/haswell: Set up DMI ASPM ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43743/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43743/1//COMMIT_MSG@8 PS1, Line 8:
Can you please elaborate a little, what DMI ASPM is.
DMI stands for `Direct Media Interface`, which is the PCIe-like link between the SA (System Agent, aka Northbridge) and the PCH.
ASPM means `Active State Power Management`, and it's a PCIe concept. DMI also has it.
On Haswell-H (e.g. Asrock B85M Pro4) we need to enable ASPM, because we enable it on the PCH but not on the SA. And this is inconsistent (both ends should have the same settings). I have to check if we need to do this on Haswell-LP or not, though.
Given the context (Intel Haswell), the DMI and ASPM acronyms should be clear enough. However, I will clarify the commit summary and message, to explicitly state that we are enabling DMI ASPM, and *why* we are doing so.