Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31813 )
Change subject: Fix up remaining boolean uses of CONFIG_XXX to CONFIG(XXX)
......................................................................
Patch Set 1:
Not sure if this is the way to go. The original intention
of IS_ENABLED(), as I understood it, was to avoid problems
with undefined CONFIG_* macros. For instance in CPP, an
undefined CONFIG_ would be true for an #if, and one defined
to 0 would be true for an #ifdef. IS_ENABLED() solved that
very nicely.
In C, we have other issues. I would always prefer a plain
`CONFIG_...` in C, simply because it results in a compile
time error when the config is undefined.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31813
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa0573a535addc3354a74e944c0920befb0666be
Gerrit-Change-Number: 31813
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 08 Mar 2019 13:55:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment