build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45615 )
Change subject: nb/intel/gm45: Move DEFAULT_MCHBAR to Kconfig ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45615/2/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45615/2/src/northbridge/intel/gm45/... PS2, Line 234: #define MCHBAR8(x) *((volatile u8 *)(CONFIG_DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45615/2/src/northbridge/intel/gm45/... PS2, Line 235: #define MCHBAR16(x) *((volatile u16 *)(CONFIG_DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45615/2/src/northbridge/intel/gm45/... PS2, Line 236: #define MCHBAR32(x) *((volatile u32 *)(CONFIG_DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses