Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39234 )
Change subject: sc7180: clock: Add support to bump CPU levels
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39234/1/src/soc/qualcomm/sc7180/clo...
File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/39234/1/src/soc/qualcomm/sc7180/clo...
PS1, Line 314: udelay(1);
Please use the wait_us() helper from <timer.h>, e.g. […]
Done
https://review.coreboot.org/c/coreboot/+/39234/1/src/soc/qualcomm/sc7180/clo...
PS1, Line 326: pll_init_and_set(apss_silver, L_VAL_1516P8MHz);
Would print the information.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iafd3b618fb72e0e8cc8dd297e4a3e16b83550883
Gerrit-Change-Number: 39234
Gerrit-PatchSet: 4
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Taniya Das
tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Mar 2020 10:33:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Taniya Das
tdas@codeaurora.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment